angryzero/rust-rcon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: guard against page-navigation race + deprecation warning

Browse Source 
- playerInfo refresh() now early-returns if DOM elements are gone
  (happens when navigating away while getPlayers RCON is in flight)
- swiched donutLabelsOutside(false) → labelsOutside(false) to
  silence NVD3 deprecation warning

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
angryzero
2026-06-13 18:56:51 +02:00
co-authored by Copilot
parent e2e766378b
commit aa9bd725aa
2 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/pages/playerInfo.js
+14 -7
View File
@@ -40,19 +40,25 @@ function PlayerInfoPage(params, container) {
function refresh() {
Rcon.getPlayers(function (players) {
// Guard against navigation away while waiting for RCON response
var nf = document.getElementById('pi-notfound');
var fields = document.getElementById('pi-fields');
var actions = document.getElementById('pi-actions');
if (!nf || !fields || !actions) return;
var info = null;
for (var i = 0; i < players.length; i++) {
if (String(players[i].SteamID) === userid) { info = players[i]; break; }
}
if (!info) {
document.getElementById('pi-notfound').style.display = 'block';
document.getElementById('pi-fields').innerHTML = '';
document.getElementById('pi-actions').style.display = 'none';
nf.style.display = 'block';
fields.innerHTML = '';
actions.style.display = 'none';
return;
}
document.getElementById('pi-notfound').style.display = 'none';
document.getElementById('pi-actions').style.display = 'block';
nf.style.display = 'none';
actions.style.display = 'block';
// Fix known Rust RCON quirk: VoiationLevel → ViolationLevel
if (info.VoiationLevel !== undefined) {
@@ -64,7 +70,8 @@ function PlayerInfoPage(params, container) {
delete info.CurrentLevel;
delete info.UnspentXp;
document.getElementById('pi-username').textContent = info.DisplayName || userid;
var un = document.getElementById('pi-username');
if (un) un.textContent = info.DisplayName || userid;
var fieldsHtml = '';
for (var key in info) {
@@ -79,7 +86,7 @@ function PlayerInfoPage(params, container) {
fieldsHtml += '<div class="col-sm-4"><p>' + key + ': <span class="badge">' + value + '</span></p></div>';
}
}
document.getElementById('pi-fields').innerHTML = fieldsHtml;
fields.innerHTML = fieldsHtml;
});
}